You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed on a very large mutation that createHTMLDocument was a significant portion of the processing time. It appears that unnattachedDoc is only used in one specific branch, so rather than create it every time processMutation is called, I moved it so that it is only created in the branch where it is used.
This improves a couple of the benchmarks, while the others appear to be unaffected either way:
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@YunFeng0817@Juice10 can this PR be approved/merged? We just ran into this performance improvement as well and would really like to incorporate it into our use case
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on a very large mutation that createHTMLDocument was a significant portion of the processing time. It appears that
unnattachedDocis only used in one specific branch, so rather than create it every timeprocessMutationis called, I moved it so that it is only created in the branch where it is used.This improves a couple of the benchmarks, while the others appear to be unaffected either way:
Before:
After:
